]> xenbits.xensource.com Git - xen.git/commit
tools: link executables with libtinfo explicitly
authorDaniel Kiper <daniel.kiper@oracle.com>
Tue, 2 Jun 2015 13:33:26 +0000 (15:33 +0200)
committerIan Campbell <ian.campbell@citrix.com>
Wed, 3 Jun 2015 10:12:03 +0000 (11:12 +0100)
commitb248d32f4fce6f5ea1d59228cc435b80c3b50351
tree262014e742212746c9c03a5ad78f2d13f4c790f5
parentc81d06f2097fe5e10dff773880c2fb8af8c892ea
tools: link executables with libtinfo explicitly

binutils 2.22 changed ld default from --copy-dt-needed-entries
to -no-copy-dt-needed-entries. This revealed that some objects
are linked implicitly with libtinfo and newer ld fails to build
relevant executables.

Below is short explanation why we should not do that...

http://fedoraproject.org/wiki/UnderstandingDSOLinkChange says:

The default behaviour for ld (my note: before version 2.22) allows
users to 'indirectly' link to required objects/libraries through
intermediate objects/libraries. While this is convenient, it can
also be dangerous because it makes your program's dependencies tied
to the dependencies of other objects. If those objects ever change
their linkages, they can break your program without any changes
to your own code!

Signed-off-by: Daniel Kiper <daniel.kiper@oracle.com>
Acked-by: Wei Liu <wei.liu2@citrix.com>
config/Tools.mk.in
tools/configure
tools/configure.ac
tools/misc/Makefile
tools/xenstat/xentop/Makefile