]> xenbits.xensource.com Git - libvirt.git/commit
qemu_command: Separate domain features building into a helper
authorMichal Privoznik <mprivozn@redhat.com>
Tue, 26 Jul 2022 13:45:08 +0000 (15:45 +0200)
committerMichal Privoznik <mprivozn@redhat.com>
Mon, 1 Aug 2022 08:36:27 +0000 (10:36 +0200)
commitb185abe9d964e656bdc8ff9c44c982cd5384d976
tree3b905f80320af40efbb99f756bdbfc8a51cae970
parentf7baee531ac10b07914ecd04cb0e4de0d2d10a2b
qemu_command: Separate domain features building into a helper

The qemuBuildMachineCommandLine() function is needlessly long.
Separate out parts that generate arguments based on
domainDef->features[] into
qemuAppendDomainFeaturesMachineParam(). Unfortunately, expected
outputs for some qemuxml2argvdata cases needed to be updated
because the order in which features are generated is changed. But
there's no functional change.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Peter Krempa <pkrempa@redhat.com>
12 files changed:
src/qemu/qemu_command.c
tests/qemuxml2argvdata/firmware-auto-efi-enrolled-keys.x86_64-latest.args
tests/qemuxml2argvdata/firmware-auto-efi-loader-secure.x86_64-latest.args
tests/qemuxml2argvdata/firmware-auto-efi-nvram.x86_64-latest.args
tests/qemuxml2argvdata/firmware-auto-efi-secboot.x86_64-latest.args
tests/qemuxml2argvdata/firmware-auto-efi.x86_64-latest.args
tests/qemuxml2argvdata/firmware-manual-efi-secure.args
tests/qemuxml2argvdata/machine-smm-off.x86_64-latest.args
tests/qemuxml2argvdata/machine-smm-on.x86_64-latest.args
tests/qemuxml2argvdata/machine-vmport-opt.args
tests/qemuxml2argvdata/q35-virt-manager-basic.args
tests/qemuxml2argvdata/tseg-explicit-size.x86_64-latest.args