]> xenbits.xensource.com Git - people/liuw/libxenctrl-split/libvirt.git/commit
check for cfg->spiceTLS earlier in qemuProcessSPICEAllocatePorts
authorJán Tomko <jtomko@redhat.com>
Wed, 9 Jul 2014 08:57:33 +0000 (10:57 +0200)
committerJán Tomko <jtomko@redhat.com>
Thu, 10 Jul 2014 07:47:20 +0000 (09:47 +0200)
commitb02fca79e858dc6e6d3209a44fe967f038ac6291
tree496557ae8e64429043b4a1e9c18fbcd9bd31654a
parentddf6b139cfebee4193bf6f0b13c995a182d7bc35
check for cfg->spiceTLS earlier in qemuProcessSPICEAllocatePorts

This saves a few lines of code and catches the error when:
<spice autoport ='yes' defaultMode='any' ..>
  <channel name='main' mode='secure'/>
</spice>
is specified with spice_tls = 0 in qemu.conf.

Instead of this error in qemuBuildGraphicsSPICECommandLine:
error: unsupported configuration: spice secure channels set in XML
configuration, but TLS port is not provided

an error is reported in qemuProcessSPICEAllocatePorts:
error: unsupported configuration: Auto allocation of spice TLS port
requested but spice TLS is disabled in qemu.conf

Inspired by:
https://www.redhat.com/archives/libvir-list/2014-June/msg01408.html
src/qemu/qemu_process.c