]> xenbits.xensource.com Git - qemu-xen-4.4-testing.git/commit
xen: properly gate host writes of modified PCI CFG contents
authorJan Beulich <jbeulich@suse.com>
Wed, 10 Jun 2015 13:11:34 +0000 (14:11 +0100)
committerIan Jackson <Ian.Jackson@eu.citrix.com>
Wed, 10 Jun 2015 13:11:34 +0000 (14:11 +0100)
commitb0101be92c03396ace3de93b974fd527b2ff2779
tree01592acf959089713de3ec93eac455494413d2ef
parentc8c6ba08684f2fb8600df479b49c5511d6fed41a
xen: properly gate host writes of modified PCI CFG contents

The old logic didn't work as intended when an access spanned multiple
fields (for example a 32-bit access to the location of the MSI Message
Data field with the high 16 bits not being covered by any known field).
Remove it and derive which fields not to write to from the accessed
fields' emulation masks: When they're all ones, there's no point in
doing any host write.

This fixes a secondary issue at once: We obviously shouldn't make any
host write attempt when already the host read failed.

This is XSA-128.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
hw/pass-through.c
hw/pass-through.h