]> xenbits.xensource.com Git - people/liuw/libxenctrl-split/libvirt.git/commit
conf: fix backing store parse off-by-one
authorEric Blake <eblake@redhat.com>
Thu, 22 May 2014 03:45:02 +0000 (21:45 -0600)
committerEric Blake <eblake@redhat.com>
Thu, 22 May 2014 17:23:35 +0000 (11:23 -0600)
commitaefd9bcf9b6bbb9f1fd99abe5c1c90832be8bb93
tree908bd908081bbbd8071505d9aac15f68fd2ed64b
parent268101ea90f6d46117c83ef879182b74ff881e59
conf: fix backing store parse off-by-one

Commit 546154e parses the type attribute from a <backingStore>
element, but forgot that the earlier commit 9673418 added a
placeholder element in the same 1.2.3 release; as a result,
the C code was mistakenly allowing "none" as a type.

Similarly, the same commit allows "none" as the <format>
sub-element type, even though that has been a placeholder
since the 0.10.2 release with commit f772b3d.

* src/conf/domain_conf.c (virDomainDiskBackingStoreParse): Require
non-zero types.

Signed-off-by: Eric Blake <eblake@redhat.com>
src/conf/domain_conf.c