]> xenbits.xensource.com Git - qemu-xen-4.3-testing.git/commit
qemu-xen-trad/pt_msi_disable: do not clear all MSI flags
authorStefano Stabellini <stefano.stabellini@eu.citrix.com>
Mon, 10 Dec 2012 12:43:33 +0000 (12:43 +0000)
committerIan Jackson <Ian.Jackson@eu.citrix.com>
Fri, 22 Feb 2013 18:06:21 +0000 (18:06 +0000)
commitadf74189dd58014744a4b8c9d64407d629da5e2f
treed8e371c65768c5e1ddd95d59e5ff3af479b2e903
parent3b7917bce51cdf433924d295edcfe84f407bd1f7
qemu-xen-trad/pt_msi_disable: do not clear all MSI flags

"qemu-xen-trad: fix msi_translate with PV event delivery" added a
pt_msi_disable() call into pt_msgctrl_reg_write, clearing the MSI flags
as a consequence. MSIs get enabled again soon after by calling
pt_msi_setup.

However the MSI flags are only setup once in the pt_msgctrl_reg_init
function, so from the QEMU point of view the device has lost some
important properties, like for example PCI_MSI_FLAGS_64BIT.

This patch fixes the bug by clearing only the MSI
enabled/mapped/initialized flags in pt_msi_disable.

Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Tested-by: G.R. <firemeteor@users.sourceforge.net>
Xen-devel: http://marc.info/?l=xen-devel&m=135489879503075
hw/pt-msi.c