]> xenbits.xensource.com Git - libvirt.git/commit
conf: Avoid NULL dereference in virDomainNetPortForwardFree
authorJiri Denemark <jdenemar@redhat.com>
Wed, 11 Jan 2023 08:25:58 +0000 (09:25 +0100)
committerJiri Denemark <jdenemar@redhat.com>
Wed, 11 Jan 2023 08:25:58 +0000 (09:25 +0100)
commita82d74dd75a3e47d075874a7254da7b243a033ff
tree6c0cfaff2c90ffd51b73fc2263ab5a913c086780
parentf0a514dbba824dc91433d729f05bdd6d4221c2e1
conf: Avoid NULL dereference in virDomainNetPortForwardFree

In our current code the function is not called with NULL argument, but
we should follow our common practice and make it safe anyway.

Reported by coverity:

    /src/conf/domain_conf.c: 2635 in virDomainNetPortForwardFree()
    2629     {
    2630         size_t i;
    2631
    2632         if (pf)
    2633             g_free(pf->dev);
    2634
    >>>     CID 404359:  Null pointer dereferences  (FORWARD_NULL)
    >>>     Dereferencing null pointer "pf".
    2635         for (i = 0; i < pf->nRanges; i++)
    2636             g_free(pf->ranges[i]);
    2637
    2638         g_free(pf->ranges);
    2639         g_free(pf);
    2640     }

Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
Reviewed-by: Pavel Hrdina <phrdina@redhat.com>
src/conf/domain_conf.c