]> xenbits.xensource.com Git - people/liuw/libxenctrl-split/libvirt.git/commit
libxl: fix regression introduced by commit 4ab8cd77
authorJim Fehlig <jfehlig@suse.com>
Sat, 14 Mar 2015 00:36:04 +0000 (18:36 -0600)
committerJim Fehlig <jfehlig@suse.com>
Mon, 16 Mar 2015 17:49:58 +0000 (11:49 -0600)
commita7d6b94a00c6d13430229e9ac77e82c8be578337
tree4e3bcd7415c991e0236f9d4fc0d7fc08490906cf
parentee744b5b387b5123ee40683c52ab40783ffc3020
libxl: fix regression introduced by commit 4ab8cd77

Commit 4ab8cd77 added a check requiring input devices to have
a bus type of VIR_DOMAIN_INPUT_BUS_USB, failing to start the
domain otherwise.  But virDomainDefParseXML adds implicit mouse
and keyboard if a graphics device is configured.  See calls to
virDomainDefMaybeAddInput.

The regression is fixed by removing the check requiring USB input
devices, and skipping non-USB input devices when populating USB
'usbdevice' in libxl_domain_build_info struct.
src/libxl/libxl_conf.c