]> xenbits.xensource.com Git - qemu-upstream-4.4-testing.git/commit
address_space_translate: do not cross page boundaries
authorStefano Stabellini <Stefano.Stabellini@eu.citrix.com>
Thu, 30 Jan 2014 12:46:05 +0000 (12:46 +0000)
committerStefano Stabellini <stefano.stabellini@eu.citrix.com>
Mon, 3 Feb 2014 10:50:03 +0000 (10:50 +0000)
commita41087bc7110e8378cd49ddd06aa7c9d361f3673
tree55222033d7f2deb7768f09568f19613dc1eab0b9
parent90d35066387e1d9c9deeda042c5a907cd57c11cf
address_space_translate: do not cross page boundaries

The following commit:

commit 149f54b53b7666a3facd45e86eece60ce7d3b114
Author: Paolo Bonzini <pbonzini@redhat.com>
Date:   Fri May 24 12:59:37 2013 +0200

    memory: add address_space_translate

breaks Xen support in QEMU, in particular the Xen mapcache. The effect
is that one Windows XP installation out of ten would end up with BSOD.

The reason is that after this commit l in address_space_rw can span a
page boundary, however qemu_get_ram_ptr still calls xen_map_cache asking
to map a single page (if block->offset == 0).

Fix the issue by reverting to the previous behaviour: do not return a
length from address_space_translate_internal that can span a page
boundary.

Also in address_space_translate do not ignore the length returned by
address_space_translate_internal.

This patch should be backported to QEMU 1.6.x.

upstream-commit-id: 360e607b88a23d378f6efaa769c76d26f538234d

Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Signed-off-by: Anthony Perard <anthony.perard@citrix.com>
Tested-by: Paolo Bonzini <pbonzini@redhat.com>
Acked-by: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-stable@nongnu.org
exec.c