]> xenbits.xensource.com Git - libvirt.git/commit
Fix possible invalid read in adminClientGetInfo
authorJán Tomko <jtomko@redhat.com>
Wed, 29 Jun 2016 05:03:13 +0000 (07:03 +0200)
committerJán Tomko <jtomko@redhat.com>
Wed, 29 Jun 2016 14:13:12 +0000 (16:13 +0200)
commita3f565b3397f198160ef7591d6979fc8630c673a
treed4f53ebef3f8f4dc090dbf088d90ebdb03c29d19
parentca5d51df27567ef8d77c126815d01c484deb359f
Fix possible invalid read in adminClientGetInfo

virNetServerClientGetInfo returns the client's remote address
as a string, which is a part of the client object.

Use VIR_STRDUP to make a copy which can be freely accessed
even after the virNetServerClient object is unlocked.

To reproduce, put a sleep between virObjectUnlock in
virNetServerClientGetInfo and virTypedParamsAddString in
adminClientGetInfo, then close the queried connection during
that sleep.
daemon/admin_server.c
src/rpc/virnetserverclient.c
src/rpc/virnetserverclient.h