]> xenbits.xensource.com Git - qemu-xen.git/commit
target/s390x/arch_dump: Fix memory corruption in s390x_write_elf64_notes()
authorThomas Huth <thuth@redhat.com>
Tue, 14 Feb 2023 14:10:56 +0000 (15:10 +0100)
committerMichael Tokarev <mjt@tls.msk.ru>
Thu, 30 Mar 2023 09:19:04 +0000 (12:19 +0300)
commita3c6cd83e32d7729889b3eab2a9b6b4650c56ea9
treea41699c76247556213f0ed537ac1b593939ad6a7
parenta2efa1fac49b7d7d10564ef0007b2ed02e69fdf5
target/s390x/arch_dump: Fix memory corruption in s390x_write_elf64_notes()

"note_size" can be smaller than sizeof(note), so unconditionally calling
memset(notep, 0, sizeof(note)) could cause a memory corruption here in
case notep has been allocated dynamically, thus let's use note_size as
length argument for memset() instead.

Reported-by: Sebastian Mitterle <smitterl@redhat.com>
Fixes: 113d8f4e95 ("s390x: pv: Add dump support")
Message-Id: <20230214141056.680969-1-thuth@redhat.com>
Reviewed-by: Janosch Frank <frankja@linux.ibm.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Thomas Huth <thuth@redhat.com>
(cherry picked from commit eb60026120081430d554c9cabaa36c4ac271fce0)
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
target/s390x/arch_dump.c