]> xenbits.xensource.com Git - xen.git/commit
x86/HVM: make vmsi_deliver() return proper error values
authorJan Beulich <jbeulich@suse.com>
Thu, 5 Jun 2014 15:46:13 +0000 (17:46 +0200)
committerJan Beulich <jbeulich@suse.com>
Thu, 5 Jun 2014 15:46:13 +0000 (17:46 +0200)
commita296e5383b9291db566df105a8efbdc68c517f39
tree70b82b7ee7bff88eeda4b1bfb140cda8e6a659e2
parenta34dfb4ec1ac5c398b1160ad4a5ee290b717dd6d
x86/HVM: make vmsi_deliver() return proper error values

... and propagate this from hvm_inject_msi(). In the course of this I
spotted further room for cleanup:
- vmsi_inj_irq()'s struct domain * parameter was unused
- vmsi_deliver() pointlessly passed on dest_ExtINT to vmsi_inj_irq()
  (which that one validly refused to handle)
- vmsi_inj_irq()'s sole caller guarantees a proper delivery mode (i.e.
  rather than printing an obscure message we can just BUG())
- some formatting and log message quirks

Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
xen/arch/x86/hvm/irq.c
xen/arch/x86/hvm/vmsi.c