]> xenbits.xensource.com Git - libvirt.git/commit
Revert "qemu: Don't repeat virDomainObjEndAPI in qemuDomainBlockPull"
authorPeter Krempa <pkrempa@redhat.com>
Wed, 27 Nov 2019 12:40:14 +0000 (13:40 +0100)
committerPeter Krempa <pkrempa@redhat.com>
Wed, 27 Nov 2019 13:19:50 +0000 (14:19 +0100)
commita10eb613404fedb4ce44ec47848710fdb3d7a91d
tree5634c4d1afe9671522a0a17904f3fc01b941e3af
parentc8579871a980e7cd41df50afad62e9c3183534c6
Revert "qemu: Don't repeat virDomainObjEndAPI in qemuDomainBlockPull"

This reverts commit 421c9550f5446729b513ee50f5c44e6f6969b5a2

qemuDomainBlockPullCommon calls virDomainObjEndAPI internally so the
original commit made us shed two references of @vm instead of one
getting us into a premature free of @vm.

This is not a straight revert as qemuDomainBlockPull was modified
meanwhile. I've also added a warning comment that @vm is consumed.

https://bugzilla.redhat.com/show_bug.cgi?id=1777230

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
src/qemu/qemu_driver.c