]> xenbits.xensource.com Git - libvirt.git/commit
qemu: command: Don't downgrade to '-usb' for arm based machines
authorPeter Krempa <pkrempa@redhat.com>
Wed, 21 Feb 2024 16:41:01 +0000 (17:41 +0100)
committerPeter Krempa <pkrempa@redhat.com>
Wed, 6 Mar 2024 15:30:37 +0000 (16:30 +0100)
commita07544c0d78012de81e941b42ec593f0ae5f2d3a
tree7c71eca7883f7fe230802d50d3f1b2aff4937a57
parent5b136eba6db2cf16490f334c22f271a72512ef63
qemu: command: Don't downgrade to '-usb' for arm based machines

 - 'virt*' machines already don't allow downgrade
 - 'versatilepb' and 'realview' machines use 'pci-ohci' controller with '-usb'
 - all other machines ignore '-usb' (some have sysbus-based USB
   controller which we don't even consider)

For the 'versatilepb' and 'realview' machines libvirt would already
resort to picking either an existing controller model or trying to pick
the one which '-usb' would select and thus fail either way.

All other machine types ignore it.

We can thus remove the fallback for all arm-based machines.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Andrea Bolognani <abologna@redhat.com>
src/qemu/qemu_command.c
tests/qemuxmlconfdata/aarch64-nousb-minimal.aarch64-latest.abi-update.args
tests/qemuxmlconfdata/aarch64-nousb-minimal.aarch64-latest.args
tests/qemuxmlconfdata/arm-vexpressa9-basic.aarch64-latest.args
tests/qemuxmlconfdata/arm-vexpressa9-nodevs.aarch64-latest.args
tests/qemuxmlconfdata/arm-vexpressa9-virtio.aarch64-latest.args
tests/qemuxmlconfdata/disk-arm-virtio-sd.aarch64-latest.args
tests/qemuxmlconfdata/usb-controller-default-unavailable-versatilepb-armv7l.armv7l-latest.args [deleted file]
tests/qemuxmlconfdata/usb-controller-default-unavailable-versatilepb-armv7l.armv7l-latest.err [new file with mode: 0644]
tests/qemuxmlconftest.c