]> xenbits.xensource.com Git - xen.git/commit
x86/cpuid: Fix HLE and RTM handling (again)
authorAndrew Cooper <andrew.cooper3@citrix.com>
Thu, 15 Jul 2021 07:40:02 +0000 (09:40 +0200)
committerJan Beulich <jbeulich@suse.com>
Thu, 15 Jul 2021 07:40:02 +0000 (09:40 +0200)
commit9eece400c626655b826d5b1b4933e65af3073ab8
treebee700d6ee59ccc908215f28283eed04ad45d1b1
parent2c9da5f73c3a2378036c982bf0b189b34befc403
x86/cpuid: Fix HLE and RTM handling (again)

For reasons which are my fault, but I don't recall why, the
FDP_EXCP_ONLY/NO_FPU_SEL adjustment uses the whole special_features[] array
element, not the two relevant bits.

HLE and RTM were recently added to the list of special features, causing them
to be always set in guest view, irrespective of the toolstacks choice on the
matter.

Rewrite the logic to refer to the features specifically, rather than relying
on the contents of the special_features[] array.

Fixes: 8fe24090d9 ("x86/cpuid: Rework HLE and RTM handling")
Reported-by: Edwin Török <edvin.torok@citrix.com>
Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Reviewed-by: Jan Beulich <jbeulich@suse.com>
master commit: 60fa12dbf1d4d2c4ffe1ef34b495b24aa7e41aa0
master date: 2021-06-07 15:43:35 +0100
xen/arch/x86/cpuid.c