]> xenbits.xensource.com Git - qemu-upstream-4.6-testing.git/commit
xenfb: avoid reading twice the same fields from the shared page
authorStefano Stabellini <stefano.stabellini@eu.citrix.com>
Fri, 18 Dec 2015 15:10:09 +0000 (15:10 +0000)
committerStefano Stabellini <stefano.stabellini@eu.citrix.com>
Fri, 18 Dec 2015 15:28:46 +0000 (15:28 +0000)
commit9e304f572ac98265f5e7433b6490077962acda97
tree076f0ae319bbeb9762abc125d9cd60e4ecc95a55
parentfdd64c7720b98af20c9e63ae04b868d06341bfdc
xenfb: avoid reading twice the same fields from the shared page

Reading twice the same field could give the guest an attack of
opportunity. In the case of event->type, gcc could compile the switch
statement into a jump table, effectively ending up reading the type
field multiple times.

This is part of XSA-155.

Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
hw/display/xenfb.c