]> xenbits.xensource.com Git - qemu-xen.git/commit
block/rbd: fix handling of holes in .bdrv_co_block_status
authorPeter Lieven <pl@kamp.de>
Thu, 13 Jan 2022 14:44:25 +0000 (15:44 +0100)
committerKevin Wolf <kwolf@redhat.com>
Tue, 1 Feb 2022 14:14:12 +0000 (15:14 +0100)
commit9e302f64bb407a9bb097b626da97228c2654cfee
tree8a27a270f33c21f03327e48f2cf04a571a1cb225
parent111fbd74f67575c158d9be5363825aab8be50a0a
block/rbd: fix handling of holes in .bdrv_co_block_status

the assumption that we can't hit a hole if we do not diff against a snapshot was wrong.

We can see a hole in an image if we diff against base if there exists an older snapshot
of the image and we have discarded blocks in the image where the snapshot has data.

Fix this by simply handling a hole like an unallocated area. There are no callbacks
for unallocated areas so just bail out if we hit a hole.

Fixes: 0347a8fd4c3faaedf119be04c197804be40a384b
Suggested-by: Ilya Dryomov <idryomov@gmail.com>
Cc: qemu-stable@nongnu.org
Signed-off-by: Peter Lieven <pl@kamp.de>
Message-Id: <20220113144426.4036493-2-pl@kamp.de>
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
block/rbd.c