]> xenbits.xensource.com Git - people/tklengyel/xen.git/commit
tools/libs: Fix headers.chk logic
authorAndrew Cooper <andrew.cooper3@citrix.com>
Thu, 4 Mar 2021 22:30:00 +0000 (22:30 +0000)
committerAndrew Cooper <andrew.cooper3@citrix.com>
Thu, 11 Mar 2021 17:27:48 +0000 (17:27 +0000)
commit9e23f10eb0db5ffa06f1a43f74fac790992a85c7
tree52db578668345d881606e06dda10f3683f1147cd
parent368096b9c4a273be58dd897e996e3e010bcfc21b
tools/libs: Fix headers.chk logic

c/s 4664034cd dropped the $(LIBHEADERSGLOB) dependency for the headers.chk
rule, without replacing it.

As headers.chk uses $^, a typical build looks like:

  andrewcoop@andrewcoop:/local/xen.git$ make -C tools/libs/devicemodel/
  make: Entering directory '/local/xen.git/tools/libs/devicemodel'
  for i in ; do \
      gcc -x c -ansi -Wall -Werror -I/local/xen.git/tools/libs/devicemodel/../../../tools/include \
            -S -o /dev/null $i || exit 1; \
      echo $i; \
  done >headers.chk.new
  mv headers.chk.new headers.chk

i.e. with an empty for loop.

Reinsert a $(LIBHEADERS) dependency, so more than just the $(AUTOINCS) get
checked.

Fixes: 4664034cd ("tools/libs: move official headers to common directory")
Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Reviewed-by: Juergen Gross <jgross@suse.com>
Release-Acked-by: Ian Jackson <iwj@xenproject.org>
tools/libs/libs.mk