]> xenbits.xensource.com Git - xen.git/commit
tools/oxenstored: Reject invalid watch paths early
authorEdwin Török <edvin.torok@citrix.com>
Fri, 15 Jan 2021 19:28:37 +0000 (19:28 +0000)
committerIan Jackson <iwj@xenproject.org>
Fri, 19 Mar 2021 13:46:25 +0000 (13:46 +0000)
commit9b299ec2ebd80b40b731ce81a77dc9e09c74c1e2
treeb96101da68ed2699e6fbe21879a01dc6224fa6b3
parent131d98fcd47fdb62548f022635fb4adc09e83a32
tools/oxenstored: Reject invalid watch paths early

Watches on invalid paths were accepted, but they would never trigger.  The
client also got no notification that its watch is bad and would never trigger.

Found again by the structured fuzzer, due to an error on live update reload:
the invalid watch paths would get rejected during live update and the list of
watches would be different pre/post live update.

The testcase is watch on `//`, which is an invalid path.

Signed-off-by: Edwin Török <edvin.torok@citrix.com>
Acked-by: Christian Lindig <christian.lindig@citrix.com>
Release-Acked-by: Ian Jackson <iwj@xenproject.org>
(cherry picked from commit dc8caf214fb882546b0e93317b9828247a7c9da8)
tools/ocaml/xenstored/connection.ml
tools/ocaml/xenstored/connections.ml