]> xenbits.xensource.com Git - arm/linux.git/commit
ASoC: topology: Prevent use-after-free in snd_soc_get_pcm_runtime()
authorDragos Tarcatu <dragos_tarcatu@mentor.com>
Wed, 4 Dec 2019 21:04:47 +0000 (15:04 -0600)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 1 Feb 2020 09:34:42 +0000 (09:34 +0000)
commit98aedb8935551b1e8934e3482c6b8e6884da8fba
tree9866a635f66eb8e07db1c2d8a401a99bb04f21ab
parent68b74847c8bcec2728332c8929ae3d3cf0e83338
ASoC: topology: Prevent use-after-free in snd_soc_get_pcm_runtime()

[ Upstream commit dd836ddf4e4e1c7f1eb2ae44783ccd70872ef24e ]

remove_link() is currently calling snd_soc_remove_dai_link() after
it has already freed the memory for the link name. But this is later
read from snd_soc_get_pcm_runtime() causing a KASAN use-after-free
warning. Reorder the cleanups to fix this issue.

Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Signed-off-by: Dragos Tarcatu <dragos_tarcatu@mentor.com>
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Link: https://lore.kernel.org/r/20191204210447.11701-4-pierre-louis.bossart@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
sound/soc/soc-topology.c