]> xenbits.xensource.com Git - qemu-upstream-4.3-testing.git/commit
xen: properly gate host writes of modified PCI CFG contents
authorJan Beulich <jbeulich@suse.com>
Tue, 2 Jun 2015 16:08:06 +0000 (16:08 +0000)
committerStefano Stabellini <stefano.stabellini@eu.citrix.com>
Tue, 2 Jun 2015 16:08:06 +0000 (16:08 +0000)
commit95963913d95670501380699ba52422032827d276
treeb690ef653f5efcdbfd3bd288ea6cc861bc793eda
parentd7b34893e0ad5c84d898b34fda8a465dfd7e8376
xen: properly gate host writes of modified PCI CFG contents

The old logic didn't work as intended when an access spanned multiple
fields (for example a 32-bit access to the location of the MSI Message
Data field with the high 16 bits not being covered by any known field).
Remove it and derive which fields not to write to from the accessed
fields' emulation masks: When they're all ones, there's no point in
doing any host write.

This fixes a secondary issue at once: We obviously shouldn't make any
host write attempt when already the host read failed.

This is XSA-128.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
hw/xen_pt.c
hw/xen_pt.h
hw/xen_pt_config_init.c