]> xenbits.xensource.com Git - xen.git/commit
x86emul/test: don't use *_len symbols
authorJan Beulich <JBeulich@suse.com>
Tue, 24 Jan 2017 16:22:03 +0000 (16:22 +0000)
committerWei Liu <wei.liu2@citrix.com>
Tue, 24 Jan 2017 16:22:03 +0000 (16:22 +0000)
commit9315fa0ef736d1153c98ce42bff5853da5ec697f
treec37aae5429daf241f0bbc3923e8e1d61c471ab39
parent98297f09bd07bb63407909aae1d309d8adeb572e
x86emul/test: don't use *_len symbols

... as they don't work as intended with -fPIC.

I did prefer them over *_end ones at the time because older gcc would
cause .L* symbols to be public, due to issuing .globl for all
referenced externals. And labels at the end of instructions collide
with the ones at the start of the next instruction, making disassembly
harder to grok. Luckily recent gcc no longer issues those .globl
directives, and hence .L* labels, staying local by default, no longer
get in the way.

Reported-by: Wei Liu <wei.liu2@citrix.com>
Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Wei Liu <wei.liu2@citrix.com>
Tested-by: Wei Liu <wei.liu2@citrix.com>
tools/tests/x86_emulator/test_x86_emulator.c