]> xenbits.xensource.com Git - xen.git/commit
x86: Improve information from domain_crash_synchronous
authorAndrew Cooper <andrew.cooper3@citrix.com>
Fri, 4 Oct 2013 10:58:20 +0000 (12:58 +0200)
committerJan Beulich <jbeulich@suse.com>
Fri, 4 Oct 2013 10:58:20 +0000 (12:58 +0200)
commit8e0da8c07f4f80e14314977a11f738bd74a5b62b
treed3452ba8506a6d9bfe12a412489215dbaa24c316
parentfe06795e82922f8d8c8910da545ef1215cbb1b8c
x86: Improve information from domain_crash_synchronous

As it currently stands, the string "domain_crash_sync called from entry.S" is
not helpful at identifying why the domain was crashed, and a debug build of
Xen doesn't help the matter

This patch improves the information printed, by pointing to where the crash
decision was made.

Specific improvements include:
 * Moving the ascii string "domain_crash_sync called from entry.S\n" away from
   some semi-hot code cache lines.
 * Moving the printk into C code (especially as this_cpu() is miserable to use
   in assembly code)
 * Undo the previous confusing situation of having the
   domain_crash_synchronous() as a macro in C code, yet a global symbol in
   assembly code.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Acked-by: Keir Fraser <keir@xen.org>
xen/arch/x86/traps.c
xen/arch/x86/x86_64/compat/entry.S
xen/arch/x86/x86_64/entry.S
xen/include/asm-x86/asm_defns.h
xen/include/xen/sched.h