]> xenbits.xensource.com Git - qemu-xen-4.3-testing.git/commit
pcnet: force the buffer access to be in bounds during tx
authorPetr Matousek <pmatouse@redhat.com>
Sun, 24 May 2015 08:53:44 +0000 (10:53 +0200)
committerIan Jackson <Ian.Jackson@eu.citrix.com>
Tue, 23 Jun 2015 10:43:35 +0000 (11:43 +0100)
commit8d882026216a2b9afe74d4b1ef99433620e0ba0a
tree478e51bef6f90d5d1b4378cc85e929efb68853e6
parent13cb33af28dfd3a1b4d681509fc5348899a03b15
pcnet: force the buffer access to be in bounds during tx

4096 is the maximum length per TMD and it is also currently the size of
the relay buffer pcnet driver uses for sending the packet data to QEMU
for further processing. With packet spanning multiple TMDs it can
happen that the overall packet size will be bigger than sizeof(buffer),
which results in memory corruption.

Fix this by only allowing to queue maximum sizeof(buffer) bytes.

This is CVE-2015-3209.

Signed-off-by: Petr Matousek <pmatouse@redhat.com>
Reported-by: Matt Tait <matttait@google.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
hw/pcnet.c