]> xenbits.xensource.com Git - libvirt.git/commit
phyp: reduce scope of driver functions
authorEric Blake <eblake@redhat.com>
Thu, 24 Jun 2010 21:05:16 +0000 (15:05 -0600)
committerEric Blake <eblake@redhat.com>
Fri, 25 Jun 2010 13:52:43 +0000 (07:52 -0600)
commit89144534ebea806704e05769942bd3bebf23d8e4
treecaa33122f39a3f5f5b8002e9798a26fb8883ae9a
parentf9a921462963f59c6018246678cb397f9f3e3d71
phyp: reduce scope of driver functions

Several phyp functions are not namespace clean, and had no reason
to be exported since no one outside the phyp driver needed to use
them.  Rather than do lots of forward declarations, I was able
to topologically sort the file.  So, this patch looks huge, but
is really just a matter of marking things static and dealing with
the compiler fallout.

* src/phyp/phyp_driver.h (PHYP_DRIVER_H): Add include guard.
(phypCheckSPFreeSapce): Delete unused declaration.
(phypGetSystemType, phypGetVIOSPartitionID, phypCapsInit)
(phypBuildLpar, phypUUIDTable_WriteFile, phypUUIDTable_ReadFile)
(phypUUIDTable_AddLpar, phypUUIDTable_RemLpar, phypUUIDTable_Pull)
(phypUUIDTable_Push, phypUUIDTable_Init, phypUUIDTable_Free)
(escape_specialcharacters, waitsocket, phypGetLparUUID)
(phypGetLparMem, phypGetLparCPU, phypGetLparCPUGeneric)
(phypGetRemoteSlot, phypGetBackingDevice, phypDiskType)
(openSSHSession): Move declarations to phyp_driver.c and make static.
* src/phyp/phyp_driver.c: Rearrange file contents to provide
topological sorting of newly-static funtions (no semantic changes
other than reduced scope).
(phypGetBackingDevice, phypDiskType): Mark unused, for now.
src/phyp/phyp_driver.c
src/phyp/phyp_driver.h