]> xenbits.xensource.com Git - people/liuw/libxenctrl-split/libvirt.git/commit
util: don't support loopback and nbd when setuid
authorEric Blake <eblake@redhat.com>
Sat, 29 Mar 2014 19:04:47 +0000 (13:04 -0600)
committerEric Blake <eblake@redhat.com>
Tue, 1 Apr 2014 16:38:14 +0000 (10:38 -0600)
commit885ac290ea8742d3f156aa70a6ef18620d431e8b
tree257d75f0efeae0a70370d66b558f1a175a0eeb75
parent5160ab795ac0c2feb9ad60f981c6d93e6373cb5a
util: don't support loopback and nbd when setuid

The only remaining reason that virt-login-shell was trying to
link against virstoragefile was because of a call to
virStorageFileFormatTypeToString when spawning a qemu-nbd
process - but setuid processes shouldn't be spawning qemu-nbd.

* src/util/virfile.c (virFileLoopDeviceAssociate)
(virFileNBDDeviceAssociate): Cripple in setuid builds.
* src/Makefile.am (libvirt_setuid_rpc_client_la_SOURCES):
Drop virstoragefile from the list.

Signed-off-by: Eric Blake <eblake@redhat.com>
src/Makefile.am
src/util/virfile.c