]> xenbits.xensource.com Git - libvirt.git/commit
qemuBuildCpuCommandLine: Don't leak @buf
authorMichal Privoznik <mprivozn@redhat.com>
Fri, 8 Jul 2016 16:17:35 +0000 (18:17 +0200)
committerMichal Privoznik <mprivozn@redhat.com>
Mon, 11 Jul 2016 12:21:01 +0000 (14:21 +0200)
commit87df945240dcd9769d6fd6dbddfb2bb5601b349d
tree500ff0a2fff5a033ba52ca5891cf68d482687e47
parentb04835258f3ea97c37f6a1aed370c6a2b29c58b2
qemuBuildCpuCommandLine: Don't leak @buf

Just like every other qemuBuild*CommandLine() function, this uses
a buffer to hold partial cmd line strings too. However, if
there's an error, the control jumps to 'cleanup' label leaving
the buffer behind and thus leaking it.

==2013== 1,006 bytes in 1 blocks are definitely lost in loss record 701 of 711
==2013==    at 0x4C29F80: malloc (vg_replace_malloc.c:296)
==2013==    by 0x4C2C32F: realloc (vg_replace_malloc.c:692)
==2013==    by 0xAD925A8: virReallocN (viralloc.c:245)
==2013==    by 0xAD95EA8: virBufferGrow (virbuffer.c:130)
==2013==    by 0xAD95F78: virBufferAdd (virbuffer.c:165)
==2013==    by 0x5097F5: qemuBuildCpuModelArgStr (qemu_command.c:6339)
==2013==    by 0x509CC3: qemuBuildCpuCommandLine (qemu_command.c:6437)
==2013==    by 0x51142C: qemuBuildCommandLine (qemu_command.c:9174)
==2013==    by 0x47CA3A: qemuProcessCreatePretendCmd (qemu_process.c:5546)
==2013==    by 0x433698: testCompareXMLToArgvFiles (qemuxml2argvtest.c:332)
==2013==    by 0x4339AC: testCompareXMLToArgvHelper (qemuxml2argvtest.c:413)
==2013==    by 0x446E7A: virTestRun (testutils.c:179)

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
src/qemu/qemu_command.c