]> xenbits.xensource.com Git - qemu-upstream-4.6-testing.git/commit
char: remove watch callback on chardev detach from frontend
authorAmit Shah <amit.shah@redhat.com>
Wed, 28 Aug 2013 09:54:05 +0000 (15:24 +0530)
committerMichael Roth <mdroth@linux.vnet.ibm.com>
Tue, 3 Dec 2013 03:18:10 +0000 (21:18 -0600)
commit8501da4b93959ccbae4d04a673d0f1c5b72b1a4b
tree684e2326b4f6de51e6b15f4b14b517b8a5a1970d
parentaeefaaac83a38a563a0511d6012abea5c49a3165
char: remove watch callback on chardev detach from frontend

If a frontend device releases the chardev (via unplug), the chr handlers
are set to NULL via qdev's exit callbacks invoking
qemu_chr_add_handlers().  If the chardev had a pending operation, a
callback will be invoked, which will try to access data in the
just-released frontend, causing a segfault.

Ensure the callbacks are disabled when frontends release chardevs.

This was seen when a virtio-serial port was unplugged when heavy
guest->host IO was in progress (causing a callback to be registered).
In the window in which the throttling was active, unplugging ports
caused a qemu segfault.

https://bugzilla.redhat.com/show_bug.cgi?id=985205

CC: <qemu-stable@nongnu.org>
Reported-by: Sibiao Luo <sluo@redhat.com>
Reviewed-by: Gerd Hoffmann <kraxel@redhat.com>
Signed-off-by: Amit Shah <amit.shah@redhat.com>
(cherry picked from commit 386a5a1e0057e220f79c48fe3689e3dfb17f1b09)

Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
qemu-char.c