]> xenbits.xensource.com Git - qemu-upstream-unstable.git/commit
migration/block: fix pending() return value
authorVladimir Sementsov-Ogievskiy <vsementsov@parallels.com>
Tue, 30 Dec 2014 10:04:16 +0000 (13:04 +0300)
committerMichael Roth <mdroth@linux.vnet.ibm.com>
Sun, 22 Feb 2015 18:27:50 +0000 (12:27 -0600)
commit83dbd88b5ce280e26a40a22aa473a248f9bb0f5e
tree2e2df7cfae834498b4ae6556293a992a262671d7
parent718ab310169c65bd8aa5692981a0e65e6d0ca775
migration/block: fix pending() return value

Because of wrong return value of .save_live_pending() in
migration/block.c, migration finishes before the whole disk is
transferred. Such situation occurs when the migration process is fast
enough, for example when source and dest are on the same host.

If in the bulk phase we return something < max_size, we will skip
transferring the tail of the device. Currently we have "set pending to
BLOCK_SIZE if it is zero" for bulk phase, but there no guarantee, that
it will be < max_size.

True approach is to return, for example, max_size+1 when we are in the
bulk phase.

Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@parallels.com>
Message-id: 1419933856-4018-2-git-send-email-vsementsov@parallels.com
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
(cherry picked from commit 04636dc410b163c2243e66c3813dd4900a50a4ed)
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
block-migration.c