]> xenbits.xensource.com Git - qemu-upstream-4.6-testing.git/commit
qdev: Fix crash by validating the object type
authorAmos Kong <akong@redhat.com>
Wed, 16 Apr 2014 01:57:14 +0000 (09:57 +0800)
committerMichael Roth <mdroth@linux.vnet.ibm.com>
Mon, 21 Jul 2014 03:14:21 +0000 (22:14 -0500)
commit837e02ef07179876ca2ada2ed67d3eeaa9d3a9d7
treed45a782ba1dc8f652c7761564c4e581d49ae92a0
parent46a1b0e489cdb604da81ebde985c35ff798601dc
qdev: Fix crash by validating the object type

QEMU crashed when I try to list device parameters and the driver name is
actually an available bus name.

 # qemu -device virtio-pci-bus,?
 # qemu -device virtio-bus,?
 # qemu -device virtio-serial-bus,?
 qdev-monitor.c:212:qdev_device_help: Object 0x7fd932f50620 is not an
 instance of type device
 Aborted (core dumped)

We can also reproduce this bug by adding device from monitor, so it's
worth to fix the crash.

 (qemu) device_add virtio-serial-bus
 qdev-monitor.c:491:qdev_device_add: Object 0x7f5e89530920 is not an
 instance of type device
 Aborted (core dumped)

Cc: qemu-stable@nongnu.org
Signed-off-by: Amos Kong <akong@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Andreas Färber <afaerber@suse.de>
(cherry picked from commit ce0abca3e35a9f95e9edcb5d6b2910b2fcd52099)
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
qdev-monitor.c