]> xenbits.xensource.com Git - libvirt.git/commit
util: reject unknown flags, and prefer unsigned flags
authorEric Blake <eblake@redhat.com>
Wed, 6 Jul 2011 22:29:02 +0000 (16:29 -0600)
committerEric Blake <eblake@redhat.com>
Wed, 13 Jul 2011 15:04:54 +0000 (09:04 -0600)
commit833fe8abec3592c0b89efce3669621263937ad1f
tree08178ee83a852a74ff44d929dd2877ed108878a4
parent01ed9b56d18b4bb7fb129135f3d2105d84cc5ade
util: reject unknown flags, and prefer unsigned flags

Silently ignored flags get in the way of new features that
use those flags.  Also, an upcoming syntax check will favor
unsigned flags.

* src/nodeinfo.h (nodeGetCPUStats, nodeGetMemoryStats): Drop
unused attribute.
* src/interface/netcf_driver.c (interfaceOpenInterface)
(interfaceDefineXML, interfaceCreate, interfaceDestroy): Reject
unknown flags.
* src/network/bridge_driver.c (networkOpenNetwork)
(networkGetXMLDesc): Likewise.
* src/nwfilter/nwfilter_driver.c (nwfilterOpen): Likewise.
* src/secret/secret_driver.c (secretOpen, secretDefineXML)
(secretGetXMLDesc, secretSetValue): Likewise.
* src/util/logging.c (virLogDefineFilter, virLogDefineOutput)
(virLogMessage): Likewise; also use unsigned flags.
* src/util/logging.h (virLogDefineFilter, virLogDefineOutput)
(virLogMessage): Change signature.
* src/util/command.c (virExecWithHook): Likewise.
src/interface/netcf_driver.c
src/network/bridge_driver.c
src/nodeinfo.h
src/nwfilter/nwfilter_driver.c
src/secret/secret_driver.c
src/util/command.c
src/util/logging.c
src/util/logging.h