]> xenbits.xensource.com Git - xen.git/commit
AMD/IOMMU: drop stray MSI enabling
authorJan Beulich <jbeulich@suse.com>
Tue, 4 Feb 2025 12:50:49 +0000 (13:50 +0100)
committerJan Beulich <jbeulich@suse.com>
Tue, 4 Feb 2025 12:50:49 +0000 (13:50 +0100)
commit83187a21fd9bc26e23472ea351153ff8f7c2a7b8
tree261dae1875acf23e42866a2f38590751d19e77be
parent39c45caef271bc2b2e299217450cfda24c0c772a
AMD/IOMMU: drop stray MSI enabling

While the 2nd of the commits referenced below should have moved the call
to amd_iommu_msi_enable() instead of adding another one, the situation
wasn't quite right even before: It can't have done any good to enable
MSI when no IRQ was allocated for it, yet.

The other call to amd_iommu_msi_enable(), just out of patch context,
needs to stay there until S3 resume is re-worked. For the boot path that
call should be unnecessary, as iommu{,_maskable}_msi_startup() will have
done it already (by way of invoking iommu_msi_unmask()).

Fixes: 5f569f1ac50e ("AMD/IOMMU: allow enabling with IRQ not yet set up")
Fixes: d9e49d1afe2e ("AMD/IOMMU: adjust setup of internal interrupt for x2APIC mode")
Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Jason Andryuk <jason.andryuk@amd.com>
Tested-by: Jason Andryuk <jason.andryuk@amd.com>
Acked-by: Roger Pau Monné <roger.pau@citrix.com>
Release-Acked-by: Oleksii Kurochko<oleksii.kurochko@gmail.com>
xen/drivers/passthrough/amd/iommu_init.c