]> xenbits.xensource.com Git - libvirt.git/commit
src: Don't use virReportSystemError() on virProcessGetStatInfo() failure
authorMichal Privoznik <mprivozn@redhat.com>
Wed, 18 Jan 2023 08:03:29 +0000 (09:03 +0100)
committerMichal Privoznik <mprivozn@redhat.com>
Mon, 23 Jan 2023 15:16:03 +0000 (16:16 +0100)
commit818c9717c53446ca7abbaa7b3fd7925e1c5ab663
treefc88462f33fc48e05cab3ea3bf860746c02571a8
parent1c7476c8797b7f0d6e8d607f6a42c5bf43441677
src: Don't use virReportSystemError() on virProcessGetStatInfo() failure

Firstly, the virProcessGetStatInfo() does not fail really. But
even if it did, it sets correct errno only sometimes (and even
that is done in a helper it's calling - virProcessGetStat() and
even there it's the case only in very few error paths).

Therefore, using virReportSystemError() to report errors is very
misleading. Use plain virReportError() instead. Luckily, there
are only two places where the former was used:
chDomainHelperGetVcpus() and qemuDomainHelperGetVcpus() (not a
big surprise since CH driver is heavily inspired by QEMU driver).

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Martin Kletzander <mkletzan@redhat.com>
src/ch/ch_driver.c
src/qemu/qemu_driver.c