]> xenbits.xensource.com Git - people/liuw/libxenctrl-split/libvirt.git/commit
qemu: put usb cgroup setup in common function
authorLaine Stump <laine@laine.org>
Mon, 29 Apr 2013 20:19:19 +0000 (16:19 -0400)
committerLaine Stump <laine@laine.org>
Tue, 30 Apr 2013 01:52:28 +0000 (21:52 -0400)
commit811143c0b6f36ab4724c8b011e365609cac1a8aa
tree37b88bd9925951c0c7761683a8748a7a5b51ead7
parent6e13860cb46e74c94ee67477942693d8757cf5de
qemu: put usb cgroup setup in common function

The USB-specific cgroup setup had been inserted inline in
qemuDomainAttachHostUsbDevice and qemuSetupCgroup, but now there is a
common cgroup setup function called for all hostdevs, so it makes sens
to put the usb-specific setup there and just rely on that function
being called.

The one thing I'm uncertain of here (and a reason for not pushing
until after release) is that previously hostdev->missing was checked
only when starting a domain (and cgroup setup for the device skipped
if missing was true), but with this consolidation, it is now checked
in the case of hotplug as well. I don't know if this will have any
practical effect (does it make sense to hotplug a "missing" usb
device?)
src/qemu/qemu_cgroup.c
src/qemu/qemu_cgroup.h
src/qemu/qemu_hotplug.c