]> xenbits.xensource.com Git - qemu-upstream-4.4-testing.git/commit
qcow1: Validate L2 table size (CVE-2014-0222)
authorKevin Wolf <kwolf@redhat.com>
Thu, 5 Mar 2015 10:59:35 +0000 (10:59 +0000)
committerStefano Stabellini <stefano.stabellini@eu.citrix.com>
Thu, 5 Mar 2015 15:30:44 +0000 (15:30 +0000)
commit7e6a078090e08ad0aa882097468953122e319d00
tree53a8998a4bdaeb11fac578af132f502b4e2963a6
parent79eb55205747805fcde3b5b1533630f8142225b0
qcow1: Validate L2 table size (CVE-2014-0222)

Too large L2 table sizes cause unbounded allocations. Images actually
created by qemu-img only have 512 byte or 4k L2 tables.

To keep things consistent with cluster sizes, allow ranges between 512
bytes and 64k (in fact, down to 1 entry = 8 bytes is technically
working, but L2 table sizes smaller than a cluster don't make a lot of
sense).

This also means that the number of bytes on the virtual disk that are
described by the same L2 table is limited to at most 8k * 64k or 2^29,
preventively avoiding any integer overflows.

Cc: qemu-stable@nongnu.org
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Reviewed-by: Benoit Canet <benoit@irqsave.net>
Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
block/qcow.c