]> xenbits.xensource.com Git - people/liuw/libxenctrl-split/libvirt.git/commit
qemu: Introduce qemuDomainDefCheckABIStability
authorMichal Privoznik <mprivozn@redhat.com>
Thu, 10 Oct 2013 08:53:56 +0000 (10:53 +0200)
committerMichal Privoznik <mprivozn@redhat.com>
Fri, 11 Oct 2013 08:31:35 +0000 (10:31 +0200)
commit7d704812b9c50cd3804dd1e7f9e2ea3e75fdc847
tree214eb04bd1a4f79ebf460213d05fdd11048619d6
parentc643b64e30e2f1688791da2527be4eabf6d922af
qemu: Introduce qemuDomainDefCheckABIStability

https://bugzilla.redhat.com/show_bug.cgi?id=994364

Whenever we check for ABI stability, we have new xml (e.g. provided by
user, or obtained from snapshot, whatever) which we compare to old xml
and see if ABI won't break. However, if the new xml was produced via
virDomainGetXMLDesc(..., VIR_DOMAIN_XML_MIGRATABLE) it lacks some
devices, e.g. 'pci-root' controller. Hence, the ABI stability check
fails even though it is stable. Moreover, we can't simply fix
virDomainDefCheckABIStability because removing the correct devices is
task for the driver. For instance, qemu driver wants to remove the usb
controller too, while LXC driver doesn't. That's why we need special
qemu wrapper over virDomainDefCheckABIStability which removes the
correct devices from domain XML, produces MIGRATABLE xml and calls the
check ABI stability function.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
src/qemu/qemu_domain.c
src/qemu/qemu_domain.h
src/qemu/qemu_driver.c
src/qemu/qemu_migration.c