]> xenbits.xensource.com Git - qemu-xen.git/commit
hw/audio/virtio-snd: fix invalid param check
authorVolker Rümelin <vr_qemu@t-online.de>
Fri, 2 Aug 2024 07:18:05 +0000 (09:18 +0200)
committerMichael S. Tsirkin <mst@redhat.com>
Tue, 20 Aug 2024 10:57:47 +0000 (06:57 -0400)
commit7d14471a121878602cb4e748c4707f9ab9a9e3e2
tree94dbd84744c202022771ce41f74c16eee223f29b
parentf8e09b973ae8489b88394bff0118d19f989bf277
hw/audio/virtio-snd: fix invalid param check

Commit 9b6083465f ("virtio-snd: check for invalid param shift
operands") tries to prevent invalid parameters specified by the
guest. However, the code is not correct.

Change the code so that the parameters format and rate, which are
a bit numbers, are compared with the bit size of the data type.

Fixes: 9b6083465f ("virtio-snd: check for invalid param shift operands")
Signed-off-by: Volker Rümelin <vr_qemu@t-online.de>
Message-Id: <20240802071805.7123-1-vr_qemu@t-online.de>
Reviewed-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
hw/audio/virtio-snd.c