]> xenbits.xensource.com Git - qemu-xen-4.2-testing.git/commit
xen: properly gate host writes of modified PCI CFG contents
authorJan Beulich <jbeulich@suse.com>
Wed, 10 Jun 2015 13:17:22 +0000 (14:17 +0100)
committerIan Jackson <Ian.Jackson@eu.citrix.com>
Wed, 10 Jun 2015 13:17:22 +0000 (14:17 +0100)
commit7b85a1e9cdef8de686780a6e3506448ceca37572
tree969b7fea9951a3e30e4035bfdec65cd11f8766a2
parent63a2748f7a97462c9d967daaabaeb5749aee24ea
xen: properly gate host writes of modified PCI CFG contents

The old logic didn't work as intended when an access spanned multiple
fields (for example a 32-bit access to the location of the MSI Message
Data field with the high 16 bits not being covered by any known field).
Remove it and derive which fields not to write to from the accessed
fields' emulation masks: When they're all ones, there's no point in
doing any host write.

This fixes a secondary issue at once: We obviously shouldn't make any
host write attempt when already the host read failed.

This is XSA-128.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
hw/pass-through.c
hw/pass-through.h