]> xenbits.xensource.com Git - xen.git/commit
xen/arm: fix smpboot barriers
authorStefano Stabellini <sstabellini@kernel.org>
Wed, 7 Dec 2016 19:13:05 +0000 (11:13 -0800)
committerStefano Stabellini <sstabellini@kernel.org>
Wed, 7 Dec 2016 19:17:26 +0000 (11:17 -0800)
commit779a0e15ca0d9d5dbcbdee29b1dad9faf73bfc77
treee62158376dd06095842666b84c8273cfb584ad06
parent395010f346356f0c9639af362a0300dc6d1242bf
xen/arm: fix smpboot barriers

Remove useless smp_wmb() barrier after cpumask_set_cpu(cpuid,
&cpu_online_map), which is not synchronizing against anything.

Keep the other smp_wmb(), before the cpumask_set_cpu call, to ensure
that all writes before setting the cpu online are visible to other cpus.
For that to work properly, we need a corresponding smp_rmb() barrier,
after reading the online cpumask from other processors, which is
currently missing. Add it.

See: http://marc.info/?l=xen-devel&m=148093236307211

Signed-off-by: Stefano Stabellini <sstabellini@kernel.org>
Reviewed-by: Julien Grall <julien.grall@arm.com>
xen/arch/arm/smpboot.c