]> xenbits.xensource.com Git - libvirt.git/commit
nwfilter: remove pointless virNWFilterHashTable struct
authorDaniel P. Berrangé <berrange@redhat.com>
Thu, 26 Apr 2018 10:51:28 +0000 (11:51 +0100)
committerDaniel P. Berrangé <berrange@redhat.com>
Thu, 3 May 2018 16:00:57 +0000 (17:00 +0100)
commit77646d947810b5033d43874997538fe0590fc7c9
tree3efad9f3098bde38a9c851395df8715a9f8dc6b2
parent81cb05b7e876be735107b3a2788d3edf225fd232
nwfilter: remove pointless virNWFilterHashTable struct

The virNWFilterHashTable struct only contains a single virHashTable
member since

  commit 293d4fe2f11db98c91175525056c8883725d4b22
  Author: Daniel P. Berrange <berrange@redhat.com>
  Date:   Mon Mar 24 16:35:23 2014 +0000

    Remove pointless storage of var names in virNWFilterHashTable

Thus, this struct wrapper adds no real value over just using the
virHashTable directly, but brings the complexity of needing to derefence
the hashtable to call virHash* APIs, and adds extra memory allocation
step.

To minimize code churn this just turns virNWFilterHashTable into a
typedef aliases virHashTable.

Reviewed-by: Jiri Denemark <jdenemar@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
src/conf/nwfilter_ipaddrmap.c
src/conf/nwfilter_params.c
src/conf/nwfilter_params.h
src/nwfilter/nwfilter_dhcpsnoop.c
src/nwfilter/nwfilter_gentech_driver.c
tests/nwfilterxml2firewalltest.c