]> xenbits.xensource.com Git - unikraft/unikraft.git/commit
plat/common/x86: Fix `libukreloc` error for non-`PIE` `SMP` builds
authorSergiu Moga <sergiu@unikraft.io>
Fri, 11 Aug 2023 12:45:13 +0000 (15:45 +0300)
committerUnikraft <monkey@unikraft.io>
Fri, 11 Aug 2023 16:09:28 +0000 (16:09 +0000)
commit762cc5db03ece3677bbc64faa084f88b540c8ae9
tree5c95fbc4a52859e692acd28147608cf23b91ec61
parentae1cb65410f66666f65befb7f92d9f09d5e90bdb
plat/common/x86: Fix `libukreloc` error for non-`PIE` `SMP` builds

After the merge of
commit cf8cc65cb0ae ("plat/kvm/x86: Make SMP init code resolve its own `start16` relocations")
SMP builds that were not built with `libukreloc` would fail due to
external references to `x86_start16_*` symbols no longer being declared.

Thus, fix this by making their declaration present regardless of
`CONFIG_LIBUKRELOC` being enabled or not. Furthermore, guard the no
longer necessary `START16_UKRELOC_*` macro's, as they are not needed
if the previously mentioned configuration is not enabled.

Signed-off-by: Sergiu Moga <sergiu@unikraft.io>
Reviewed-by: Marco Schlumpp <marco@unikraft.io>
Approved-by: Razvan Deaconescu <razvand@unikraft.io>
Tested-by: Unikraft CI <monkey@unikraft.io>
GitHub-Closes: #1037
plat/common/x86/lcpu.c
plat/common/x86/start16_helpers.h