]> xenbits.xensource.com Git - qemu-xen.git/commit
projects / qemu-xen.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 96d922a) | patch
loader: Fix read_targphys() to behave when read() fails
authorMarkus Armbruster <armbru@redhat.com>
Wed, 16 Nov 2011 18:41:56 +0000 (19:41 +0100)
committerBlue Swirl <blauwirbel@gmail.com>
Sat, 19 Nov 2011 11:23:42 +0000 (11:23 +0000)
commit725e14e91f80b6b2c07b75b66b7b042a9fa9340c
tree093a3bfc53e586113b29cd69702cf8b9150f9c4btree
parent96d922a654f4b5a806af43d6dc6fa7c1becbbac6commit | diff
loader: Fix read_targphys() to behave when read() fails

Happily passes (size_t)-1 to rom_add_blob_fixed(), which promptly dies
attempting to malloc that much.  Spotted by Coverity.

Bonus fix for ROMs larger than INT_MAX bytes: return ssize_t instead
of int.  Bug can't bite, because the only user load_aout() limits ROM
size to an int value.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
hw/loader.c diff | blob | blame | history
hw/loader.h diff | blob | blame | history
qemu-xen (upstream qemu) tree.