]> xenbits.xensource.com Git - qemu-xen.git/commit
mac_dbdma: always clear FLUSH bit once DBDMA channel flush is complete
authorMark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Sun, 23 Aug 2015 10:50:55 +0000 (11:50 +0100)
committerMichael Roth <mdroth@linux.vnet.ibm.com>
Sat, 17 Oct 2015 23:19:14 +0000 (18:19 -0500)
commit71b685832de15374e75e382a6ff60c95ced37f82
tree641b39980540ec15065f5dfb3cbc9e211307c845
parent9a20ccaecd45f21ac4766ae6634aaa5499ddc772
mac_dbdma: always clear FLUSH bit once DBDMA channel flush is complete

The code to flush the DBDMA channel was effectively duplicated in
dbdma_control_write(), except for the fact that the copy executed outside of a
RUN bit transition was broken by not clearing the FLUSH bit once the flush was
complete.

Newer PPC Linux kernels would timeout waiting for the FLUSH bit to clear again
after submitting a FLUSH command. Fix this by always clearing the FLUSH bit
once the channel flush is complete and removing the repeated code.

Reported-by: Aurelien Jarno <aurelien@aurel32.net>
Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Reviewed-by: Aurelien Jarno <aurelien@aurel32.net>
Signed-off-by: Alexander Graf <agraf@suse.de>
(cherry picked from commit 1cde732d88af34849343dc1f0e68072eab0841b9)
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
hw/misc/macio/mac_dbdma.c