]> xenbits.xensource.com Git - libvirt.git/commit
apparmor: drop useless call to get_profile_name
authorChristian Ehrhardt <christian.ehrhardt@canonical.com>
Wed, 16 Oct 2019 07:15:14 +0000 (09:15 +0200)
committerChristian Ehrhardt <christian.ehrhardt@canonical.com>
Thu, 21 Nov 2019 07:26:06 +0000 (08:26 +0100)
commit70cf0af7bf34b6c0f3c009efc8366767dcd3c27d
tree604ce09a8cc94411d16c8e3e1e9fca157a5ff37b
parent9d38bce689557923c786ee4b36457830a167801c
apparmor: drop useless call to get_profile_name

reload_profile calls get_profile_name for no particular gain, lets
remove that call. The string isn't used in that function later on
and not registered/passed anywhere.

It can only fail if it either can't allocate or if the
virDomainDefPtr would have no uuid set (which isn't allowed).

Thereby the only "check" it really provides is if it can allocate the
string to then free it again.

This was initially added in [1] when the code was still in
AppArmorRestoreSecurityImageLabel (later moved) and even back then had
no further effect than described above.

[1]: https://libvirt.org/git/?p=libvirt.git;a=blob;f=src/security/security_apparmor.c;h=16de0f26f41689e0c50481120d9f8a59ba1f4073;hb=bbaecd6a8f15345bc822ab4b79eb0955986bb2fd#l487

Reviewed-by: Cole Robinson <crobinso@redhat.com>
Acked-by: Jamie Strandboge <jamie@canonical.com>
Signed-off-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>
src/security/security_apparmor.c