]> xenbits.xensource.com Git - qemu-xen-4.5-testing.git/commit
The old logic didn't work as intended when an access spanned multiple
authorJan Beulich <jbeulich@suse.com>
Tue, 9 Jun 2015 15:31:57 +0000 (16:31 +0100)
committerIan Jackson <Ian.Jackson@eu.citrix.com>
Tue, 9 Jun 2015 15:31:57 +0000 (16:31 +0100)
commit6fc82bfe038cc1df32231268cda018b1310549d3
treee5a3cec973a98bee0abf06140cfa528c7f6b3150
parente42b84cf1c524d017208b981c7749dc5945dda72
The old logic didn't work as intended when an access spanned multiple
fields (for example a 32-bit access to the location of the MSI Message
Data field with the high 16 bits not being covered by any known field).
Remove it and derive which fields not to write to from the accessed
fields' emulation masks: When they're all ones, there's no point in
doing any host write.

This fixes a secondary issue at once: We obviously shouldn't make any
host write attempt when already the host read failed.

This is XSA-128.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
hw/pass-through.c
hw/pass-through.h