]> xenbits.xensource.com Git - qemu-xen.git/commit
tcg/{i386, s390x}: Add earlyclobber to the op_add2's first output
authorIlya Leoshkevich <iii@linux.ibm.com>
Wed, 19 Jul 2023 22:11:18 +0000 (00:11 +0200)
committerMichael Tokarev <mjt@tls.msk.ru>
Mon, 31 Jul 2023 06:10:51 +0000 (09:10 +0300)
commit6f7c39a912a601f40681426b16f772db3697e2d1
treedefa3ad9a499c8b95420c91c01c09d9bbd68f3bc
parent59a728a031abaf8a069e91484d6d1b0f18b41f72
tcg/{i386, s390x}: Add earlyclobber to the op_add2's first output

i386 and s390x implementations of op_add2 require an earlyclobber,
which is currently missing. This breaks VCKSM in s390x guests. E.g., on
x86_64 the following op:

    add2_i32 tmp2,tmp3,tmp2,tmp3,tmp3,tmp2   dead: 0 2 3 4 5  pref=none,0xffff

is translated to:

    addl     %ebx, %r12d
    adcl     %r12d, %ebx

Introduce a new C_N1_O1_I4 constraint, and make sure that earlyclobber
of aliased outputs is honored.

Cc: qemu-stable@nongnu.org
Fixes: 82790a870992 ("tcg: Add markup for output requires new register")
Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20230719221310.1968845-7-iii@linux.ibm.com>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
(cherry picked from commit 22d2e5351a18aff5a9c7e3984b50ecce61ff8975)
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
tcg/i386/tcg-target-con-set.h
tcg/i386/tcg-target.c.inc
tcg/s390x/tcg-target-con-set.h
tcg/s390x/tcg-target.c.inc
tcg/tcg.c