]> xenbits.xensource.com Git - qemu-upstream-4.4-testing.git/commit
xen: properly gate host writes of modified PCI CFG contents
authorJan Beulich <jbeulich@suse.com>
Tue, 2 Jun 2015 15:43:07 +0000 (15:43 +0000)
committerStefano Stabellini <stefano.stabellini@eu.citrix.com>
Tue, 2 Jun 2015 15:55:16 +0000 (15:55 +0000)
commit6f2eba230a58dca80266df094a26dce5013df549
tree52eee3f21b3613f85721bae3d4855cd525fad593
parent50590fb0c104ac3ed7dc1817994ae1e11dcc6a3c
xen: properly gate host writes of modified PCI CFG contents

The old logic didn't work as intended when an access spanned multiple
fields (for example a 32-bit access to the location of the MSI Message
Data field with the high 16 bits not being covered by any known field).
Remove it and derive which fields not to write to from the accessed
fields' emulation masks: When they're all ones, there's no point in
doing any host write.

This fixes a secondary issue at once: We obviously shouldn't make any
host write attempt when already the host read failed.

This is XSA-128.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
hw/xen/xen_pt.c
hw/xen/xen_pt.h
hw/xen/xen_pt_config_init.c