]> xenbits.xensource.com Git - qemu-upstream-4.3-testing.git/commit
xenfb: avoid reading twice the same fields from the shared page
authorStefano Stabellini <stefano.stabellini@eu.citrix.com>
Fri, 18 Dec 2015 15:45:14 +0000 (15:45 +0000)
committerStefano Stabellini <stefano.stabellini@eu.citrix.com>
Fri, 18 Dec 2015 15:52:12 +0000 (15:52 +0000)
commit6e184363e64a0610c35ca231bfc73cea56eb02f3
tree304b213fc7ef466a5704093f5c6e55080a854f13
parentca37f03bc0df4d4a2c5aef4c3c445a183e6bd11b
xenfb: avoid reading twice the same fields from the shared page

Reading twice the same field could give the guest an attack of
opportunity. In the case of event->type, gcc could compile the switch
statement into a jump table, effectively ending up reading the type
field multiple times.

This is part of XSA-155.

Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
hw/xenfb.c