]> xenbits.xensource.com Git - xen.git/commit
x86/vpt: fully init timers before putting onto list
authorJan Beulich <jbeulich@suse.com>
Tue, 15 Jun 2021 13:14:20 +0000 (15:14 +0200)
committerJan Beulich <jbeulich@suse.com>
Tue, 15 Jun 2021 13:14:20 +0000 (15:14 +0200)
commit6d622f3a96bbd76ce8422c6e3805e6609417ec76
tree614334e7ec8d20dfc7cda1b648fc7a31f864b479
parentfe6630ddc4e8a8fbf8dd28a1bc58e3881393f9c1
x86/vpt: fully init timers before putting onto list

With pt_vcpu_lock() no longer acquiring the pt_migrate lock, parties
iterating the list and acting on the timers of the list entries will no
longer be kept from entering their loops by create_periodic_time()'s
holding of that lock. Therefore at least init_timer() needs calling
ahead of list insertion, but keep this and set_timer() together.

Fixes: 8113b02f0bf8 ("x86/vpt: do not take pt_migrate rwlock in some cases")
Reported-by: Igor Druzhinin <igor.druzhinin@citrix.com>
Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>
Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
xen/arch/x86/hvm/vpt.c