]> xenbits.xensource.com Git - libvirt.git/commit
qemu: Don't add -spice port=0 when no port is specified
authorChristophe Fergeau <cfergeau@redhat.com>
Wed, 16 Mar 2016 11:11:58 +0000 (12:11 +0100)
committerChristophe Fergeau <cfergeau@redhat.com>
Mon, 21 Mar 2016 09:43:40 +0000 (10:43 +0100)
commit6d28ef912c3cc9ca53ee00d82fc8ed75dc33ed9d
tree57418ed5a1e3f2e280b630fb509ca4ce438192a4
parent8dab3d1d19e407f547034d4d39bfe7a4864bf201
qemu: Don't add -spice port=0 when no port is specified

If a <graphics type='spice'> has no port nor tlsPort set, the generated
QEMU command line will contain -spice port=0.
This is later going to be ignored by spice-server, but it's better not
to add it at all in this situation.
As an empty -spice is not allowed, we still need to append port=0 if we
did not add any other argument.
src/qemu/qemu_command.c
tests/qemuxml2argvdata/qemuxml2argv-graphics-spice-no-args.args [new file with mode: 0644]
tests/qemuxml2argvdata/qemuxml2argv-graphics-spice-no-args.xml [new file with mode: 0644]
tests/qemuxml2argvdata/qemuxml2argv-video-virtio-gpu-spice-gl.args
tests/qemuxml2argvtest.c